Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Improve key value selection #66

Open
SetTrend opened this issue May 3, 2023 · 8 comments
Open

[Feature] Improve key value selection #66

SetTrend opened this issue May 3, 2023 · 8 comments
Assignees
Labels
enhancement New feature or request planned 📑
Milestone

Comments

@SetTrend
Copy link

SetTrend commented May 3, 2023

Describe the problem this feature would solve

As a programmer, I'm rather focussed to handle apps using the keyboard than using the mouse or other gesture device. That's why I'd like to suggest to improve accessibility of the 2fast app by adding more keyboard shortcuts. This would ease handling a lot.

Describe the solution

  1. When the app opens, the list of registered clients should receive focus from the beginning.

  2. The list of registered clients should be scrollable using cursor keys, like UP ARROW / DOWN ARROW / HOME / END / PAGE UP / PAGE DOWN.

  3. Hitting ENTER (or RETURN, resp.) should copy the corresponding list item's current value to the clipboard:

    Improve keyboard support

  4. Moreover, hitting any of the number keys (1 to 0) should copy the corresponding list item's current value to the clipboard:
    2fa - 2
    This way, the first 10 list items' values can easily and quickly be copied.

  5. Finally, I suggest the clickable area for copying a list item's value to be extended to encompass all three StackPanel items:

    1. The current value
    2. The copy icon
    3. The countdown icon

    2fa - 1
    This will make it easier to copy the current item's value using the mouse or similar gesture device without giving it too much thought.


@SetTrend SetTrend changed the title [Feature] Improve keyboard navigation [Feature] Improve key value selection May 3, 2023
@jp-weber jp-weber self-assigned this May 3, 2023
@jp-weber jp-weber added the enhancement New feature or request label May 3, 2023
@jp-weber
Copy link
Member

Thank you for the corresponding suggestion :)

The implementation would be done in several steps, as the implementation of copying the code with tab and enter was easy to implement at first.
2fa_tab_and_copy

The start and order of tab navigation is something i need to look at, this will probably require an option in the settings to not change the operation by default for ease of use or for the controller.

@SetTrend
Copy link
Author

Marvellous job! Thanks!

@SetTrend
Copy link
Author

Today I updated to the latest version. I looks like none of the changes you described is available in the production version yet?

@jp-weber
Copy link
Member

The change was implemented after the release of current version 1.2.6, this will definitely be included in the next maintenance update 1.2.7.

@jp-weber jp-weber added this to the 1.2.7 milestone Jul 31, 2023
@SetTrend
Copy link
Author

Hi, just wanted to ring a bell for this feature request ☺️

@jp-weber
Copy link
Member

jp-weber commented Aug 5, 2024

This turns out to be more difficult than expected with the tab input. The initial main shell brings the focus to the hamburger button every time, but I don't want to overwrite the design instead only set the focus in the code behind. Even a focus on the listview of the accounts only works correctly once a navigation has been executed again.

The extended input with numbers should work if a control command is included (CTRL or something else).

@jp-weber jp-weber modified the milestones: 1.2.7, 1.4.0 Aug 5, 2024
@SetTrend
Copy link
Author

SetTrend commented Aug 6, 2024

Thank you for your kind reply!

Hmm, this is an UWP app, isn't it? Would the following suggestion help?

https://learn.microsoft.com/en-us/answers/questions/566115/how-to-set-focus-on-a-primary-button-in-an-input-d#answers

(It's making use of the form's GotFocus event.)

@jp-weber
Copy link
Member

jp-weber commented Aug 29, 2024

Yes, it is exactly this function, but it does not work immediately after logging in, it only works after a navigation, e.g. to the settings. This is still a puzzle that needs to be solved.

But I have implemented point four from your suggestion in version 1.3.1, see the RC release https://github.com/2fast-team/2fast/releases/tag/v1.3.1-rc1.

If the list of accounts has the focus, you can navigate to the account by holding down the menu button (ALT) and entering the corresponding number (even with more than 9 accounts) and releasing the menu button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request planned 📑
Projects
None yet
Development

No branches or pull requests

2 participants