Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acknowledgements section always gets line numbers in v6.3.1 [Which breaks arXiv submissions] #130

Open
zpleunis opened this issue May 31, 2021 · 14 comments · May be fixed by #155
Open

Acknowledgements section always gets line numbers in v6.3.1 [Which breaks arXiv submissions] #130

zpleunis opened this issue May 31, 2021 · 14 comments · May be fixed by #155
Labels
acknow acknowledgemetns problems bug bug; something to be fixed in AASTeX

Comments

@zpleunis
Copy link

Using aastex631.cls the acknowledgements section always get line numbers (i.e., also without linenumbers selected as an option).

I was able to fix this by replacing
\begin{internallinenumbers} and \end{internallinenumbers} with \ifnumlines\begin{internallinenumbers}\fi and \ifnumlines\end{internallinenumbers}\fi on lines 1240, 1249, 1296 and 1305 in the .cls file.

@gregschwarz
Copy link
Contributor

I have not been able to confirm this locally. Can you let me know what style options, if any, you are using?

@zpleunis
Copy link
Author

zpleunis commented Jun 4, 2021

Yes, I use \documentclass[twocolumn]{aastex631}. The only package that I import outside of the class file is amsmath.

@seawander
Copy link

seawander commented Jun 5, 2021

I did observe what @zpleunis saw ~2 months ago, and recorded it in my own mod of the aastex package seawander/aastex_pwned@7854f15 . Thanks for the fix, @zpleunis !

seawander added a commit to seawander/aastex_pwned that referenced this issue Jun 5, 2021
@mknote88
Copy link

I sent an email regarding this issue on March 5 and got a response (from Greg Schwarz, actually, who I assume is the same as the above). He also found that it was only replicated when amsmath was imported, which was true in my case as well. It does seem to be a conflict relating to amsmath.

@GijsMulders
Copy link

GijsMulders commented Oct 5, 2021

I also experienced this issue today (and using amsmath)
astro-ph actually rejects your manuscript if it includes line numbers anywhere, so might be worth fixing.

The solution in the opening posts works for me, replacing those four lines.

@gregschwarz
Copy link
Contributor

This is in our list for the next version. Note that you also do not have to use the \begin{acknowledgment} ... \end{acknowledgment} environment. It is primarily needed to blank out the acknowledgments when using the "anonymous" style option for dual anonymous review (DAR).

@GijsMulders
Copy link

Excellent, great to see that this is being fixed.

So the alternative to the acknowledgement environment would be to just use a \vspace{} or something?

@gregschwarz
Copy link
Contributor

gregschwarz commented Oct 5, 2021

Yes, or just create a new \section*{Acknowledgment} if you really need a section header for some reason.

@jpinedaf
Copy link

jpinedaf commented May 2, 2022

Just to check, is this bug been addressed? As mentioned earlier, arXiv rejects these submissions.

@parkus
Copy link

parkus commented Jul 11, 2022

I also received an arXiv rejection due to this, so glad it is on the list to fix.

My workaround was to simply remove the acknowledgments environment and instead just separate that paragraph from the end of the main text body with a few \\ line breaks.

@augustfly augustfly pinned this issue Jul 19, 2022
@rboston628
Copy link

Just had an arXiv rejection today due to this.

A temporary solution is, within aastex631.cls, in lines 1240 and 1249, just comment out the \begin and \end.

A better solution would need to fix the \ifx statement at line 1239 so this doesn't execute when line numbers are turned off.

@sedonaprice
Copy link

sedonaprice commented Jul 20, 2023

My fix: wrap both lines 1239-1241 and lines 1248-1250 with \ifnumlines .... \fi, then the acknowledgements follows the document-level line numbering setting.

Edit: also wrapping lines 1294-1297 and 1303-1306 with \ifnumlines .... \fi for the alternative spelling of acknowledgements.

@augustfly augustfly added bug bug; something to be fixed in AASTeX acknow acknowledgemetns problems labels Aug 2, 2023
@matiscke
Copy link

matiscke commented Sep 7, 2023

ArXiv rejected our paper due to this bug. I'm glad this issue is on the list to be fixed; I suspect it affects many users. Any news on when we can expect to see a new aastex release? I appreciate the hard work that goes into this.

@augustfly augustfly changed the title Acknowledgements section always gets line numbers in v6.3.1 Acknowledgements section always gets line numbers in v6.3.1 [Which breaks arXiv submissions] Sep 8, 2023
@augustfly
Copy link
Member

We are in fact beginning to scope out the next release, but dev hasn't started and given the issues, this might be big one. I'm really sorry this bit your arXiv release @matiscke! There are so many nests of dependencies that some clean out is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknow acknowledgemetns problems bug bug; something to be fixed in AASTeX
Projects
None yet
Development

Successfully merging a pull request may close this issue.