-
Notifications
You must be signed in to change notification settings - Fork 99
Project Meeting 2023.03.28
-
Two Zone Profiling
-
PR #660, or why we need to test much larger models
The BayDAG pull request included a change in trip scheduling that alters the results of the model for certain corner cases. The change is not detectable in the current CI test suite, which only tests a very limited number of households and does not find many corner-case errors. (The upcoming refactoring includes infrastructure to rigorously test much larger subsets of models, which is how this was discovered. For the MTC test model, the change impacts the departure time of approximately 0.7% of all simulated trips.)
This PR rolls back the model component to use the original logic by default, and allows users to upgrade to the revised logic by setting "logic_version: 2" in the model settings. If no logic level is set explicitly, a warning is emitted that "logic_version: 1" is implied, and that a future version of ActivitySim may default to logic version 2.