Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the granularity of log messages of the extension #2934

Open
Alex-302 opened this issue Sep 6, 2024 · 0 comments
Open

Improve the granularity of log messages of the extension #2934

Alex-302 opened this issue Sep 6, 2024 · 0 comments

Comments

@Alex-302
Copy link
Member

Alex-302 commented Sep 6, 2024

Issue Details

Now, it is not clear from the output in the console what was done when the filter update was triggered.

Printed filters lists are unsorted:

Details
17:31:42.249 background.js:56159 2024-09-06T17:31:42:249: Filter 4 updated successfully
17:31:43.708 background.js:56159 2024-09-06T17:31:43:708: Filter 21 updated successfully
17:31:43.738 background.js:56159 2024-09-06T17:31:43:738: Filter 18 updated successfully
17:31:43.767 background.js:56159 2024-09-06T17:31:43:767: Filter 19 updated successfully
17:31:43.771 background.js:56159 2024-09-06T17:31:43:771: Filter 3 updated successfully
17:31:43.779 background.js:56159 2024-09-06T17:31:43:779: Filter 2 updated successfully

Output a large number of duplicate strings reporting unsupported syntax.

Details
17:31:46.527  $stealth modifier does not contain any options supported by browser extension: "useragent"
17:31:46.528  $stealth modifier does not contain any options supported by browser extension: "useragent"
17:31:46.528  $stealth modifier does not contain any options supported by browser extension: "ip"
17:31:46.528  $stealth modifier does not contain any options supported by browser extension: "3p-auth"
17:31:46.528  $stealth modifier does not contain any options supported by browser extension: "3p-auth"
17:31:46.528  $stealth modifier does not contain any options supported by browser extension: "3p-auth"
17:31:46.528  $stealth modifier does not contain any options supported by browser extension: "3p-auth"
17:31:46.528  $stealth modifier does not contain any options supported by browser extension: "webrtc"
17:31:46.528  $stealth modifier does not contain any options supported by browser extension: "ip"
17:31:46.528  $stealth modifier does not contain any options supported by browser extension: "3p-auth"
17:31:46.528  $stealth modifier does not contain any options supported by browser extension: "ip"
17:31:46.528  $stealth modifier does not contain any options supported by browser extension: "ip"
17:31:46.528  $stealth modifier does not contain any options supported by browser extension: "useragent"
17:31:46.528  $stealth modifier does not contain any options supported by browser extension: "useragent"
17:31:46.528  $stealth modifier does not contain any options supported by browser extension: "webrtc"
17:31:46.528  $stealth modifier does not contain any options supported by browser extension: "3p-auth"
17:31:46.529  $stealth modifier does not contain any options supported by browser extension: "useragent"
17:31:46.529  $stealth modifier does not contain any options supported by browser extension: "3p-auth"
17:31:46.529  $stealth modifier does not contain any options supported by browser extension: "ip"
17:31:46.529  $stealth modifier does not contain any options supported by browser extension: "3p-auth"
17:31:46.529  $stealth modifier does not contain any options supported by browser extension: "webrtc"
17:31:46.529  $stealth modifier does not contain any options supported by browser extension: "3p-auth"
17:31:46.529  $stealth modifier does not contain any options supported by browser extension: "webrtc"
17:31:46.529  $stealth modifier does not contain any options supported by browser extension: "3p-auth"
17:31:46.529  $stealth modifier does not contain any options supported by browser extension: "3p-auth"
17:31:46.529  $stealth modifier does not contain any options supported by browser extension: "3p-auth"
17:31:46.529  $stealth modifier does not contain any options supported by browser extension: "useragent"
17:31:46.529  $stealth modifier does not contain any options supported by browser extension: "3p-auth"
17:31:46.529  $stealth modifier does not contain any options supported by browser extension: "ip"
17:31:46.529  $stealth modifier does not contain any options supported by browser extension: "useragent"
17:31:46.529  $stealth modifier does not contain any options supported by browser extension: "3p-auth"
17:31:46.529  $stealth modifier does not contain any options supported by browser extension: "ip"
17:31:46.529  $stealth modifier does not contain any options supported by browser extension: "ip"
17:31:46.530  $stealth modifier does not contain any options supported by browser extension: "3p-auth"
17:31:46.530  $stealth modifier does not contain any options supported by browser extension: "3p-auth"
17:31:46.530  $stealth modifier does not contain any options supported by browser extension: "useragent"
17:31:46.530  $stealth modifier does not contain any options supported by browser extension: "ip"
17:31:46.530  $stealth modifier does not contain any options supported by browser extension: "3p-auth"
17:31:46.530  $stealth modifier does not contain any options supported by browser extension: "useragent"
17:31:46.530  $stealth modifier does not contain any options supported by browser extension: "3p-auth"
17:31:46.530  $stealth modifier does not contain any options supported by browser extension: "useragent"
17:31:46.530  $stealth modifier does not contain any options supported by browser extension: "ip"
17:31:46.530  $stealth modifier does not contain any options supported by browser extension: "3p-auth"
17:31:46.530  $stealth modifier does not contain any options supported by browser extension: "ip"
17:31:46.530  $stealth modifier does not contain any options supported by browser extension: "3p-auth"
17:31:46.531  $stealth modifier does not contain any options supported by browser extension: "ip"
17:31:46.531  $stealth modifier does not contain any options supported by browser extension: "ip"
17:31:46.531  $stealth modifier does not contain any options supported by browser extension: "webrtc"
17:31:46.531  $stealth modifier does not contain any options supported by browser extension: "webrtc"
17:31:46.531  $stealth modifier does not contain any options supported by browser extension: "webrtc"
17:31:46.531  $stealth modifier does not contain any options supported by browser extension: "3p-auth"
17:31:46.531  $stealth modifier does not contain any options supported by browser extension: "useragent"
17:31:46.531  $stealth modifier does not contain any options supported by browser extension: "ip"
17:31:46.531  $stealth modifier does not contain any options supported by browser extension: "3p-auth"
17:31:46.531  $stealth modifier does not contain any options supported by browser extension: "ip"
17:31:46.531  $stealth modifier does not contain any options supported by browser extension: "3p-auth"
17:31:46.531  $stealth modifier does not contain any options supported by browser extension: "3p-auth"
17:31:46.531  $stealth modifier does not contain any options supported by browser extension: "3p-auth"
17:31:46.531  $stealth modifier does not contain any options supported by browser extension: "ip"
17:31:46.531  $stealth modifier does not contain any options supported by browser extension: "3p-auth"
17:31:46.531  $stealth modifier does not contain any options supported by browser extension: "useragent"
17:31:46.531  $stealth modifier does not contain any options supported by browser extension: "ip"
17:31:46.531  $stealth modifier does not contain any options supported by browser extension: "useragent"
17:31:46.532  $stealth modifier does not contain any options supported by browser extension: "ip"
17:31:46.532  $stealth modifier does not contain any options supported by browser extension: "webrtc"
17:31:46.532  $stealth modifier does not contain any options supported by browser extension: "3p-auth"
17:31:46.532  $stealth modifier does not contain any options supported by browser extension: "ip"
17:31:46.532  $stealth modifier does not contain any options supported by browser extension: "3p-auth"
17:31:46.532  $stealth modifier does not contain any options supported by browser extension: "ip"
17:31:46.532  $stealth modifier does not contain any options supported by browser extension: "useragent"
17:31:46.532  $stealth modifier does not contain any options supported by browser extension: "useragent"
17:31:46.532  $stealth modifier does not contain any options supported by browser extension: "3p-auth"
17:31:46.532  $stealth modifier does not contain any options supported by browser extension: "3p-auth"
17:31:46.532  $stealth modifier does not contain any options supported by browser extension: "3p-auth"
17:31:46.532  $stealth modifier does not contain any options supported by browser extension: "ip"
17:31:46.533  $stealth modifier does not contain any options supported by browser extension: "webrtc"

Proposed solution

  • Don't duplicate error messages about unsupported rules - large amount of redundant information.
  • Add versions to messages. For example
    Filter X needs to be updated => Filter X needs to be updated [1.0.0.0]
    Filter Y is already updated => Filter Y is updated [1.2.0.1]
  • Sort filters lists when print them.

Events and order:

  1. Start of filter update
    Update filters by scheduler. / Update filters forced by user.
  2. Applied method of filter update (diffs or full)
    Update method: differential / full sync
  3. The list of filters to be checked for updates
  4. The list of versions of filters being updated before updating
    Filter X needs to be updated [1.0.0.0]
  5. Versions of updated filters after update
    Filter Y is updated [1.2.0.1] or error message, if update failed
  6. Update tswebextension configuration...
  7. Print rule errors
  8. tswebextension configuration is updated. Rules count: XXXXXX
  9. End of update message
    Filters have been successfully updated.

Alternative solution

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants