Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MV3 extension - Custom filters do not update when a new version of AG MV3 is available #2944

Open
3 tasks done
SampeiNihira opened this issue Sep 14, 2024 · 2 comments
Open
3 tasks done

Comments

@SampeiNihira
Copy link

SampeiNihira commented Sep 14, 2024

Please answer the following questions for yourself before submitting an issue

  • Filters were updated before reproducing an issue
  • I checked the knowledge base and found no answer
  • I checked to make sure that this issue has not already been filed

AdGuard Extension version

5.0.78 beta

Browser version

Edge latest version

OS version

Win 10 Home x64

Ad Blocking

AdGuard Base filter

Privacy

No response

Social

No response

Annoyances

AdGuard Cookie Notices filter

Security

No response

Other

No response

Language-specific

EasyList Italy

What Tracking protection options do you have enabled?

No response

Issue Details

  1. Go to custom filters, after an extension update, and you notice that the custom filter lists even though an update was available remained the same as in the previous version of AG MV3

Expected Behavior

Obviously that in case of custom filter update,there is an update that instead there is not.

Actual Behavior

See image after updating AG MV3 from version 5.0.65 to version 5.0.78.

The filter list “Actually Legitimate URL Shortener Tool is stopped at version 19 August 2024 v.1 when version 10 September 2024 v1 is available (so the update was available before version 78 of AG MV3 came out)

https://raw.githubusercontent.com/DandelionSprout/adfilt/master/LegitimateURLShortener.txt

The filter list “EU US ads&tracking networks MV3 (third-party blocking only)” is stopped at version 08 September when ver. 10 September is available:

https://github.com/Kees1958/W3C_annual_most_used_survey_blocklist/blob/master/EU_US_MV3_most_common_ad%2Btracking_networks.txt
100

An improvement is also required for the verification of the subscribed version of custom filter lists,because the current one is rather inefficient.

Screenshots

Screenshot 1

Additional Information

No response

@alexx7311
Copy link

@SampeiNihira, hello! This is not a bug, we haven't implemented the logic to update the custom filters. You'll be able to update custom filters through 'Check for filter updates' button or through automatic updates. Not sure if we need to update custom filters on every extension update, but we'll think about it, thanks!

@SampeiNihira
Copy link
Author

Thank you.
I currently update the custom filter lists manually,that is, by removing the filter list and adding the new updated filter list,obviously if I am aware that there is an update.
If you try to install the filter lists I have inserted,you will notice that the display of the filter list itself,in my opinion,should also be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants