Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulls for Post-Pull Review by Naveen #376

Closed
4 tasks done
Allan-N opened this issue Jul 29, 2024 · 1 comment
Closed
4 tasks done

Pulls for Post-Pull Review by Naveen #376

Allan-N opened this issue Jul 29, 2024 · 1 comment
Assignees

Comments

@Allan-N
Copy link
Collaborator

Allan-N commented Jul 29, 2024

Others have made pull requests to correct reported issues. Per Tim, these pulls need to be reviewed.

If OK, please check each pull request. If changes are requested/needed, please file a new issue.

@InterLinked1
Copy link
Member

Others have made pull requests to correct reported issues. Per Tim, these pulls need to be reviewed.

If OK, please check each pull request. If changes are requested/needed, please file a new issue.

Sorry for the delay here.

363 and 373 look completely good.
366 didn't follow commit/coding guidelines, but there is no point making another change just to address that. Somebody can get that when going through and addressing that issue en masse later.
372 it might be nice to have a warning if the original config setting was invalid, but not too sure what the context is there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants