Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shouldn't IArrakisV2 be explicitely implemented by ArrakisV2 vault #170

Open
ferencdg opened this issue Oct 9, 2023 · 1 comment
Open

Comments

@ferencdg
Copy link

ferencdg commented Oct 9, 2023

Currently I don't see any 'is IArrakis' when defining the ArrakisV2 valult. I was doing some refactoring on my fork, and renamed one of the methods inside the ArrakisV2 vault (managerFeeBps), which was also defined in the IArrakisVault2. Sadly the contract compiled and then I got a runtime error after deployment for the following codeline:

 IArrakisV2 arrakisV2 = IArrakisV2(underlyingPayload_.self);

        (uint256 fee0After, uint256 fee1After) = subtractAdminFees(
            fee0,
            fee1,
            arrakisV2.managerFeeBPS()
        );
@kassandraoftroy
Copy link
Contributor

Yeah it's a good point (if the ArrakisV2 contract were to implement IArrakisV2 explicitly this would be a compile time error rather than runtime)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants