Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure library #2

Open
mialbu opened this issue Jan 24, 2023 · 0 comments
Open

Restructure library #2

mialbu opened this issue Jan 24, 2023 · 0 comments

Comments

@mialbu
Copy link
Member

mialbu commented Jan 24, 2023

For some types, there's a distinct file (e.g., Order struct in order.go) while other types are collected in the file opensea-model.go (e.g., Asset, or AssetContract). The structure should be more consistent throughout the library.

Suggestion: Create a file stat.go for Stat, asset.go for Asset and AssetContract, and collection.go for Collection.

Further, create a util file that holds different utility methods that are currently also held by opensea-model.go.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mialbu