-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fee Collector: Historical per pool summary #134
Comments
@Xeonus can you maybe provide an example output? Or do we not need this anymore (can you close it if so) |
If we are still interested in per pool performance stats / overall stats over time, I think this is valuable. We could simplify the logic and build automation based off the csvs to create a combined json file? An entry could look something like this:
|
After speaking to @Xeonus and better understanding requirements we agreed to the following. 1: Change the code such that report csvs include the round end date on each line |
Solved by #159. Awaiting review. |
To further enrich the protocol fees page, we shall create a summaries file similar to this one: https://github.com/BalancerMaxis/protocol_fee_allocator/blob/main/fee_allocator/summaries/recon.json
Ideally a json with following information:
In that manner we can plot / visualize per pool / gauge stats that give us insight for historical performance and make it easier for us to put the active fee run into context.
Directly doing API calls / calling the raw run files is inefficient. A summary json file that is created in a similar fashion like the recon.json would be ideal.
The text was updated successfully, but these errors were encountered: