Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change options for nodes in order to be closer to the desktop wallet options #592

Open
dbadol opened this issue Sep 12, 2024 · 0 comments
Open

Comments

@dbadol
Copy link

dbadol commented Sep 12, 2024

Current situation

The Desktop wallet presents the following two options for nodes:

  • "Remote node" (user must give address and port).
  • "Integrated node" (with an editable list of peers to start with).

On the other hand, the Mobile wallet presents 3 different options:

  • "Random node" (without any visible or editable list).
  • "Mobile node" (without informing that it will need an initial sync).
  • "Own node" (where user must give address and port).

Remark: The "Own node" option is the only one where the user can give an address. Thus, it can also be used to force the usage of one specific remote node (even if it is not "own"), in a similar way as it is done in the desktop wallet.

Proposal for enhancement

I believe it would be better and easier to understand if the wording in the mobile options was consistent with the one in the desktop wallet.

Thus, the options in the mobile wallet could be:

  • "Remote node" (with 2 options: Random or given by the user).
  • "Integrated node" (with a warning about the initial sync duration).

Remark: We suppose that the wallet can automatically detect if the remote node entered by the user has its owner key or not. Indeed, it's better if we can avoid having one dedicated option for "own nodes", because that's really for advanced users.

Remark: All the other current messages about sync'ing balances between multiple wallets should be removed, because they are more confusing than helping.

Alternatives

  1. The "Integrated node" could also be "Integrated mobile node" if we really want to keep it clear it is not a normal node. But I think it complicates things unnecessarily.
  2. The "Remote node" with option "Random" could also give an editable list of possible nodes to pick from.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant