Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arabic leaking into the site? #102

Open
DianaHajTPS opened this issue Oct 3, 2016 · 7 comments
Open

Arabic leaking into the site? #102

DianaHajTPS opened this issue Oct 3, 2016 · 7 comments
Assignees

Comments

@DianaHajTPS
Copy link
Collaborator

DianaHajTPS commented Oct 3, 2016

screen shot 2016-10-03 at 12 48 35 pm

I'm just noticing this. I'm not sure if it's a consequence of working on the arabic, just thought I'd flag it here.

Also I'll take this opportunity to make a reminder about the arabic fonts, listed here #70 :)

@phillipadsmith
Copy link
Member

Hi @DianaHajTPS: Quick request -- no need to assign me to tickets relating to the website. Thanks! :-)

@daveomitchell
Copy link
Member

I'm seeing it too -- as well as a Portuguese duplicate of Salt March. (These seem to be the only two pieces leaking through.)

screen shot 2016-10-03 at 11 55 02 am

I was doing some correcting of Arabic document titles this morning at Adrian's request: adding "DONE" as well as "SNAPSHOT/GALLERY/FULL." Maybe that's the cause?

@daveomitchell
Copy link
Member

updates: The Arabic translation of "Lysistrata project" is now no longer showing up, after I removed "DONE" from the document title.

The Portuguese translation of salt march is still showing up, however, even without DONE or READY in the title.

@adrian-the-git
Copy link
Contributor

I'm curious whether this is a language detection issue or related to the way modules are indexed, but whichever it is will be relatively straightforward to fix. I just don't think I'll be able to get to it until next week.

@DianaHajTPS
Copy link
Collaborator Author

Hmmm there's more Arabic now when I'm searching for keywords, are these labeled as "Done" as well Dave?

screen shot 2016-10-05 at 10 06 26 am

@daveomitchell
Copy link
Member

Ok, @adrian-the-git -- I will hold off on fixing Arabic document titles, and, @DianaHajTPS, will go back and undo the ones I've added DONE to, until this is resolved.

@daveomitchell
Copy link
Member

A further thought: going forward, it might be better to specify which subfolders different language settings pull from rather than rely on language detection, as this is only going to get more complicated as more languages get added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants