Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: How do we choose the images or videos for RWE #94

Open
DianaHajTPS opened this issue Aug 24, 2016 · 20 comments
Open

Question: How do we choose the images or videos for RWE #94

DianaHajTPS opened this issue Aug 24, 2016 · 20 comments

Comments

@DianaHajTPS
Copy link
Collaborator

If i'd like to assign each one of the RWE an image or a video, where would I place it in the google folder and how do I format it in the google doc?

@daveomitchell
Copy link
Member

My feeling is that we should keep this as simple as possible -- if the link added has a "preview" image attached, that would be displayed. If it doesn't, maybe we need some generic image?

As I see it, we're simply seeding the field here for something that will be primarily user-generated, and we don't really have the capacity for someone to be identifying images for each example that is added...

Maybe there could be the option of an "image:" override in cases where we really want to choose a specific image for a RWE and it's not displaying properly via "preview" -- that would be a question for Adrian. As for where it would go, it could go along with each RWE, at the bottom of the module's google doc.

@adrian-the-git
Copy link
Contributor

Agree about the capacity issue. It would be great if we had generics with overrides. The override in the doc would look just as Dave said, an image: key along with the RWE. As for where to upload them, that's a matter of preference but the ASSETS folder would work fine.

[real-world-examples]
title: [Pre]occup(y/ied) oysters
link: https://wearethetwopercent.biz
description: Protesters demonstrate how they add images to RWEs
image: occupy-oysters.jpg
[]

@daveomitchell
Copy link
Member

...could the "image:" value also be a URL rather than an image we've saved and uploaded? that would be the quickest/easiest of all.

@DianaHajTPS , for videos, I assume that we'd just be "link:"ing to Vimeo or YouTube clips, which have fairly reliable preview images. (and we could add an override image link if needed in cases that don't.) I think it would be a mistake for us to start uploading videos to the "Assets" folder.

@DianaHajTPS
Copy link
Collaborator Author

That is all correct. I wasn't suggesting that we'd start inputting images/videos ourselves forever. It was just a suggestion for a solution that we can use in the interim. The plan was/is that the the url would show the "preview image" associated with the url or if the url is already an image or video it would display that directly

At the moment it seems that the site is not accommodating either.
Some examples below:

After learning today that the site takes a long time to load in Nepal I even take my suggestion back.
Let me know how you'd like to proceed, but having all those RWEs be a generic image as they currently are is not ideal :(

@adrian-the-git
Copy link
Contributor

Vimeo, YouTube, and the mentioned RWE-with-a-preview-image all use opengraph meta tags. Those can be pulled each time the document is updated, and won't require an image: key in the RWE portion of the doc.

But maybe a site uses a weird image, so an image key would then override it. The case which is most difficult to address is the site with neither an opengraph tag nor an image key. Can we have some kind of default image per type, or some default pattern to display?

@daveomitchell
Copy link
Member

Looks like there now is a default pattern/image displaying -- Adrian, are you waiting on anything to be able to move forward with this, or is it (sensibly) just ranked as a lower priority than getting the Arabic site up?

Note to self: once this is functioning, I'll draft an announcement to the team (esp. Chelsea) about adding new RWEs as they come up, and possibly going back through BT's Facebook posts for good items to add...

@adrian-the-git
Copy link
Contributor

Are you waiting on anything to be able to move forward with this?

As I've mentioned, a number of sites simply don't publish any kind of image we can use. I just tested 61 RWE's and only 32 of them provide images (the images facebook would use when sharing links). Two of those were small logos, one was a tiny book cover, and one was a blank white square. I'd like some kind of guidance for what to do when we don't have an image, as that will be ~50% of the time.

@DianaHajTPS, I did what I could to construct something visually interesting to put behind these examples, but I think we all agree that using the module image with a pattern is not really appropriate. Can you devise something for the common case where no image is available, and no one has taken the time to add one?

@DianaHajTPS
Copy link
Collaborator Author

DianaHajTPS commented Oct 28, 2016

Based on evaluation feedback, the participants really want more visuals (photos, videos, etc...) One of their main complaints is that it's a text heavy site. Since the RWE was our chance to pull more media in, I'm hesitant about creating a visually appealing placeholder when there's no image/video to be grabbed.

Compromise/Suggestion: I'm happy to manually pull images/videos for the remaining 50% of the current RWEs and put them on the drive (if you can direct me where). Then moving forward for any module that gets added where an RWE happens to not have an image, the person adding it should manually add and image/video to the drive. @adrian-the-git @daveomitchell does that sound reasonable?

@adrian-the-git
Copy link
Contributor

adrian-the-git commented Oct 28, 2016

Okay cool. I will set up a system to pull these images when possible, and allow someone to override that image by adding an image: key to the RWE. The markup will look like this:

[real-world-examples]
title: Example 1
link: http://example.com/123
description: This is an example with its image pulled automatically from the link (when possible)

title: Example 2
link: http://example.com/abc
description: This is an example with an image called rwe-example-two.jpg uploaded to the ASSETS folder
image: rwe-example-two.jpg

@DianaHajTPS
Copy link
Collaborator Author

Great!

Question: Do you heave the list of the modules that need the manual adding of media? and what if it's a video, shall use the markup "image"?

@DianaHajTPS
Copy link
Collaborator Author

disregard my video question, I'll take a screenshot of the video to upload since we're not playing the video from the site.

Just the list of modules that need the manual addition please and thank you.

@adrian-the-git
Copy link
Contributor

Here's a generated list. It includes links to each doc so the image: tag can be added. Let me know if this works for you.
missing_real_world_examples.txt

@DianaHajTPS
Copy link
Collaborator Author

Perfect! I'll start working on these today.

@DianaHajTPS
Copy link
Collaborator Author

DianaHajTPS commented Nov 3, 2016

I collected all the photos, and I started adding them to Artivism, but I don't see them reflected on the site. Am I doing anything wrong? They are in the Assets folder.

Do they need to be named a certain way maybe?

@adrian-the-git
Copy link
Contributor

You're doing everything right, let me know when they're all in there and I'll pull the trigger.

@DianaHajTPS
Copy link
Collaborator Author

Ok sounds good it will probably be Monday morning. Are there certain
directions I should be following?

On Friday, November 4, 2016, adrian-the-git [email protected]
wrote:

You're doing everything right, let me know when they're all in there and
I'll pull the trigger.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#94 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJRZWA2EA3994tKwk2x18dw23Xn2faxSks5q67UEgaJpZM4JsX2-
.

Diana Haj Ahmad
Designer
The Public Society

617 378 8222 http://617.378.8222
[email protected] [email protected]
thepublicsociety.com http://www.thepublicsociety.com/

@DianaHajTPS
Copy link
Collaborator Author

Sorry I mean dimensions

On Friday, November 4, 2016, adrian-the-git [email protected]
wrote:

You're doing everything right, let me know when they're all in there and
I'll pull the trigger.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#94 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJRZWA2EA3994tKwk2x18dw23Xn2faxSks5q67UEgaJpZM4JsX2-
.

Diana Haj Ahmad
Designer
The Public Society

617 378 8222 http://617.378.8222
[email protected] [email protected]
thepublicsociety.com http://www.thepublicsociety.com/

@adrian-the-git
Copy link
Contributor

That's a good questions. At their largest size, the images are 622px wide (in the tablet layout). The images which are automatically pulled from the sites will not be cropped to ideal dimensions, so I'm going to use some best-guess css like:

background-size: cover;
background-position: 50% 30%

@DianaHajTPS
Copy link
Collaborator Author

All set! you can pull the trigger!

@DianaHajTPS
Copy link
Collaborator Author

Hi there,

Following up on this, and making sure that you saw my response :)

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants