Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Wayland support in Show Desktop applet #471

Closed
JoshStrobl opened this issue Oct 9, 2023 · 0 comments · Fixed by #485
Closed

Implement Wayland support in Show Desktop applet #471

JoshStrobl opened this issue Oct 9, 2023 · 0 comments · Fixed by #485
Assignees
@JoshStrobl
Labels
wayland Tasks related to port to Wayland
Milestone
10.9

Comments

@JoshStrobl
Copy link
Member

This is a meta-tasklist for implementation of Wayland support in Show Desktop applet, such as via use of libxfce4windowing. Strict usage of Wnck is not viable as that is limited to X11. libxfce4windowing is designed to support both X11 and Wayland.
@JoshStrobl JoshStrobl added the wayland Tasks related to port to Wayland label Oct 9, 2023
JoshStrobl added a commit that referenced this issue Oct 22, 2023
@JoshStrobl
Port Show Desktop applet to libxfce4windowing
660ed96 
Fixes #471
@JoshStrobl JoshStrobl self-assigned this Oct 22, 2023
@JoshStrobl JoshStrobl linked a pull request Oct 22, 2023 that will close this issue
Port TabSwitcher, Show Desktop & Workspace applets over to libxfce4windowing #485
Merged
@JoshStrobl JoshStrobl added this to the 10.9 milestone Oct 22, 2023
JoshStrobl added a commit that referenced this issue Oct 29, 2023
@JoshStrobl @EbonJaeger
Port TabSwitcher, Show Desktop & Workspace applets over to libxfce4wi…
74b6564 
…ndowing (#485)

* Port TabSwitcher over to libxfce4windowing

This PR ports our TabSwitcher over to libxfce4windowing from using libwnck directly. To facilitate this, considerable amounts of the code was gutted or rewritten, for example wm no longer does any sort of cur_tabs tracking. That is left up to TabSwitcher.

Instead of rebuilding tabswitcher contents every single time we invoke it, we allow it to handle its own state and handle changes based on libxfce4windowing events. Windows are added / removed automatically, workspace handling is done to support show-all-windows function and workspace swapping, and we leverage sort with our recency list and filter to know when to hide items.

* ci: change package name for libxfce4windowing devel

* Port Show Desktop applet to libxfce4windowing

Fixes #471

* Port Workspace applet

Fixes #470

* Fix typo in signal

Co-authored-by: Evan Maddock <[email protected]>

* Use construct on TabSwitcherWindow

Co-authored-by: Evan Maddock <[email protected]>

* Remove unnecessary workspace switch code.

Use warning and document backwards / forwards logic.

* Make TabSwitcherSwitch sub-class Gtk.FlowBoxChild

* Clean up bit mask checking

Co-authored-by: Evan Maddock <[email protected]>

* Use down var already defined

Co-authored-by: Evan Maddock <[email protected]>

* Cleanup extra newline

Co-authored-by: Evan Maddock <[email protected]>

---------

Co-authored-by: Evan Maddock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshStrobl JoshStrobl

Labels
wayland Tasks related to port to Wayland
Projects
Budgie 10
Status: Done
Milestone
10.9
1 participant
@JoshStrobl