Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline scaling functionality #1196

Open
5 tasks
lbianchi-lbl opened this issue Mar 1, 2024 · 0 comments · May be fixed by #1197
Open
5 tasks

Streamline scaling functionality #1196

lbianchi-lbl opened this issue Mar 1, 2024 · 0 comments · May be fixed by #1197
Assignees
Labels
Priority:Normal Normal Priority Issue or PR

Comments

@lbianchi-lbl
Copy link
Contributor

lbianchi-lbl commented Mar 1, 2024

  • Reimplement scaling/unscaling functionality in foqus_lib.framework.graph.nodeVars to support numpy/pandas data structures
  • Add testing (potentially/partially property-based, e.g. Hypothesis)
  • Register scaling functions (e.g. as Setuptools entry points) to make them accessible throughout the FOQUS codebase
  • Integrate the scaling functions in the ANN surrogate plugin ensuring that the available options match the registered scaling functions
  • Extend new scaling functionality integration to other parts of the codebase (e.g. ML/AI plugin)

To start working on (4) before (3) is complete, the following stub can be used:

# foqus_lib/framework/surrogate/scaling.py

# mapping between the human-readable name for the scaling variant
# and an instance of the corresponding scaler class
map_name_to_scaler = {
    "Linear": LinearScaler(),
    "Log": LogScaler(),
    ...
}
# foqus_lib/framework/surrogate/xyz.py

from foqus_lib.framework.surrogate.scaling import map_name_to_scaler
@franflame franflame linked a pull request Mar 1, 2024 that will close this issue
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Mar 5, 2024
@ksbeattie ksbeattie linked a pull request May 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants