15839 - E2e tests (mock data) for all of Org/Receiver/Sender Settings Pages #15921
Conversation
… Pages Fixed last Mile Failures e2e broken test
penny-lischer
added
frontend
penny-lischer
requested review from
etanb,
jpandersen87 and
victor-chaparro
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
penny-lischer
temporarily deployed
to
staging
GitHub Actions
Inactive
penny-lischer
temporarily deployed
to
staging
GitHub Actions
Inactive
penny-lischer
temporarily deployed
to
staging
GitHub Actions
Inactive
| test("nav contains the 'Admin tools' dropdown with 'Organization Settings' option", async ({ | ||
| organizationPage, |
There was a problem hiding this comment.
the indentation got lost here
| test.describe("sender user", () => { | ||
| test.use({ storageState: "e2e/.auth/sender.json" }); | ||
| test("returns Page Not Found", async ({ organizationEditPage }) => { | ||
| await expect(organizationEditPage.page).toHaveTitle(/Page Not Found/); |
There was a problem hiding this comment.
Does this work? Technically the case is incorrect here.
| }); | ||
|
|
||
| test.describe("when there is no error", () => { | ||
| test("has correct title", async ({ organizationEditPage }) => { |
There was a problem hiding this comment.
Can we please use the basepage for Header and Footer?
Should be organizationEditPage.testHeader()
There was a problem hiding this comment.
There was a problem hiding this comment.
No, because this page does not have a heading.
penny-lischer
force-pushed
the
experience/15839/org-settings-e2e
branch
from
2b13f42
to
5da43b1
Compare
penny-lischer
temporarily deployed
to
staging
GitHub Actions
Inactive
|
Branch deployed to Chromatic 🚀.
View via: |
|
|
This PR ...
-E2e tests (mock data) for all of Org/Receiver/Sender Settings
Test Steps:
Testing
./prime testor./gradlew testSmokeagainst local Docker ReportStream container?npm run lint:write?Linked Issues