Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of specific "target" for <a> links by default UI to open result documents in different frame #623

Open
IngoHolder opened this issue May 23, 2024 · 2 comments
Labels
improvement Not a bug Pagefind UI The prebuilt Pagefind UI components

Comments

@IngoHolder
Copy link

When the default UI is integrated into an existing HTML suite that uses frames, it is much more convenient for larger suites when the selected search result link is opened in e.g. a new tab or a specific frame. Therefore, a CLI option "link-target" would be useful. When specified, the given value is added to the generated pagefile-ui.js as target attribute. By setting --link-target _blank the documents are opened in a new tab, by setting --link-target myframe the documents are opened in the given frame.

@bglw
Copy link
Contributor

bglw commented May 28, 2024

Good call, that can be added. It'll be an option when constructing the Default UI in the browser though, rather than a CLI option (the CLI is unaware of anything UI-side)

@bglw bglw added improvement Not a bug Pagefind UI The prebuilt Pagefind UI components labels May 28, 2024
@IngoHolder
Copy link
Author

An option in the default UI would be fine for me as well. I just noticed that the default UI is generated as part of the index generation so I thought it could be specified there. I manually adjusted the minimized default UI to specify the target _blank and it makes the default UI much more usable in my setup. However, I have to do a "text editor" replacement after each index generation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Not a bug Pagefind UI The prebuilt Pagefind UI components
Projects
None yet
Development

No branches or pull requests

2 participants