[Closed] Add .PlaceHolder() Extension Methods

[brminnick]

After adding #38, it makes sense to also implement extension methods for Placeholder and PlaceholderColor:

	public static TBindable PlaceholderColor<TBindable>(this TBindable bindable, Color? textColor) where TBindable : BindableObject, IPlaceholder
	{
		bindable.SetValue(PlaceholderElement.PlaceholderColorProperty, textColor);
		return bindable;
	}

	public static TBindable Placeholder<TBindable>(this TBindable bindable, string? text) where TBindable : BindableObject, IPlaceholder
	{
		bindable.SetValue(PlaceholderElement.PlaceholderProperty, text);
		return bindable;
	}

	public static TBindable Placeholder<TBindable>(this TBindable bindable, string? text, Color? textColor) where TBindable : BindableObject, IPlaceholder
	{
		return bindable.Placeholder(text).PlaceholderColor(textColor);
	}

[brminnick]

A preview of the implementation and associated Unit Tests can be found on the Create-PlaceholderExtensions branch.

[pictos]

public static TBindable Placeholder<TBindable>(this TBindable bindable, string? text);

This overload shouldn't be named PlaceholderText? I'm asking because we have a specific name of Color

[brminnick]

I went with the method name .Placeholder() because the IPlaceholder property name is Placeholder:

new Entry
{
  Placeholder = "Enter Text Here"
};

This matches the existing precedence, like .FormattedText() sets the Label.FormattedText property, and .FontSize() sets the Label.FontSize property.

Since the .Placeholder() extension method will only appear for elements that implement IPlaceholder, it should always make sense to the user given the context:

new Entry().Placeholder("Name");
new Editor().Placeholder("Address");

[brminnick]

Likewise, with .PlaceholderColor(); it matches the IPlaceholder property name, IPlaceholder.PlaceholderColor

[pictos]

Yeah, that makes sense to me.

[brminnick]

Right on! Is it good enough for a Proposal?

[pictos]

Yeap! This has my approval!

[brminnick]

Promoted to Proposal: #43

[CliffAgius]

Closed and answered