Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent "testing" user from being on packet #365

Open
jabbate19 opened this issue Aug 27, 2023 · 1 comment
Open

Prevent "testing" user from being on packet #365

jabbate19 opened this issue Aug 27, 2023 · 1 comment

Comments

@jabbate19
Copy link
Collaborator

jabbate19 commented Aug 27, 2023

Add some check when populating signatures_upper to prevent adding the user testing so that we don't have to keep deleting it.

@mxmeinhold
Copy link
Collaborator

We pull all the upperclassmen at a couple of points. One is when creating new packets, another is in sync_with_ldap. Both of these rely on get_active_members

There are a few cases where the testing user can be useful to have around, such as in dev or staging, but these aren't super important. The simplest solution I think would be to exclude the testing user from the ldap responses entirely. A slightly more complex solution that would still allow for testing would be to exclude the testing user only when deployed in production. This could be something handled by an environment/config variable, or it could be something we change in the actual image build. Lots of options!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants