Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer documentation: Mapping exchange via sparse matrices is not explained #222

Open
Huite opened this issue Jan 11, 2024 · 1 comment

Comments

@Huite
Copy link
Contributor

Huite commented Jan 11, 2024

The weights for mapping from one model to another are stored in CSR matrix, and then used to do groupby reductions via a dot product. However, this is not entirely obvious and it's not documented in the dev docs.

@Huite Huite assigned Huite and deltamarnix and unassigned Huite Jan 11, 2024
@deltamarnix
Copy link
Contributor

deltamarnix commented Jan 25, 2024

I believe this ticket should be picked up by someone with a bit more understanding of what is going on. Also, there should be a split in the documentation to be written.

  • Write some documentation on how the the mapping is created by primod. What is the concept behind it? Consider if this should go in the imod coupler documentation or the primod documentation.
  • Write some documentation for developers on how to implement the mapping part, with CSR matrices. I received this blog from @Huite https://jakevdp.github.io/blog/2017/03/22/group-by-from-scratch/

@deltamarnix deltamarnix removed their assignment Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To do
Development

No branches or pull requests

2 participants