Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for dirty and mark_dirty Incorrect #634

Open
GroveDG opened this issue Mar 31, 2024 · 1 comment
Open

Documentation for dirty and mark_dirty Incorrect #634

GroveDG opened this issue Mar 31, 2024 · 1 comment
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@GroveDG
Copy link

GroveDG commented Mar 31, 2024

taffy version

0.4.1

Platform

Documentation

What went wrong

The mark_dirty and dirty functions on TaffyTree refer to marking children as outdated, but mark_dirty marks parents (and so on) as outdated.

Additional information

It could also be that the documentation is what it's supposed to do and the code is wrong. I'm not sure.

@GroveDG GroveDG added the bug Something isn't working label Mar 31, 2024
@alice-i-cecile alice-i-cecile added the documentation Improvements or additions to documentation label Apr 1, 2024
@nicoburns
Copy link
Collaborator

Pretty sure the docs are wrong here as you suspected. I reckon mark_dirty ought to be "node and it's parents/ancestors" and dirty probably ought to just say "the node" and not talk about parents/children at all.

@nicoburns nicoburns added the good first issue Good for newcomers label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants