Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReportManager rework #89

Open
JMWren opened this issue Jan 7, 2022 · 1 comment
Open

ReportManager rework #89

JMWren opened this issue Jan 7, 2022 · 1 comment
Labels
🏒 feature New feature or request 🚢 port Port existing 1.x code 🌀 version 2.0 god help us

Comments

@JMWren
Copy link
Member

JMWren commented Jan 7, 2022

This class is in a similar state to the WhitelistAppService. The logic is hard to follow as it contains a lot of branches which could likely be reduced into a more human-readable state. The report commands are relatively unused so I am not even entirely sure it works properly, but I aim to push the use of these commands more and more. Just like the WhitelistAppService rework, this class should implement its own MessageReceived listener.

Perhaps the best course of action would be to simply remove reports to all the possible ministries and exclusively focus on reports to staff.

@TptMike
Copy link
Member

TptMike commented Jan 7, 2022

All the logic pertaining to relaying messages to discord for those unsynced could be removed as those features are no longer needed. Since syncing is now required (and wasn't then), this should cut out at least half of the spaghet in the code.

@TptMike TptMike added 🏒 feature New feature or request 🌀 version 2.0 god help us 🚢 port Port existing 1.x code labels Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏒 feature New feature or request 🚢 port Port existing 1.x code 🌀 version 2.0 god help us
Projects
None yet
Development

No branches or pull requests

3 participants
@TptMike @JMWren and others