Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit merged PR and build real todo list #6

Open
allaryin opened this issue Oct 12, 2018 · 2 comments
Open

Audit merged PR and build real todo list #6

allaryin opened this issue Oct 12, 2018 · 2 comments
Assignees
Labels

Comments

@allaryin
Copy link
Member

With minimal tweaks, @Trinsdar's PR (#4) compiled and runs, so I accepted it to keep the momentum going.

Now I need to go through more thoroughly and see what precisely it contained and what else we need to do ;)

@allaryin allaryin added this to the 4.0 (Initial 1.12 Update) milestone Oct 12, 2018
@allaryin allaryin self-assigned this Oct 12, 2018
@Trinsdar
Copy link
Contributor

by the way could you perhaps give me some sort of explanation of the math used in the fir tree generation?

@allaryin
Copy link
Member Author

So the fir tree generator that I threw in there is pretty garbage (it's the autumn generator with the numbers turned up to fir scale), hence the screenshot. When I get a chance, I'm going to rewrite the original generator to something better and less horrible to read.

As far as the math involved, it's nothing fancy. We pick a height for the tree within a certain bounds and then assume that most of that will have leaves. Classic EBXL fir leaves are just a simple repeating pattern that results in a sort of stacked cone look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants