Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on prop-types #2696

Open
jonkoops opened this issue Jan 8, 2024 · 2 comments
Open

Remove dependency on prop-types #2696

jonkoops opened this issue Jan 8, 2024 · 2 comments
Assignees
Labels
Issue: Accepted The submitted issue has been confirmed by the Victory core team Type: TypeScript Issues related to typescript or type definitions

Comments

@jonkoops
Copy link

jonkoops commented Jan 8, 2024

We're trying to reduce the amount of dependencies of our React application, and noticed that prop-types is a dependency of Victory. Since all prop-types does is validate that the props passed to a component are of a certain type, we are left wondering why it could not be handled by TypeScript at compile time instead.

Would it be possible to remove prop-types as a dependency from Victory?

@carbonrobot
Copy link
Contributor

Hi @jonkoops We are actively working on upgrading all components right now. I don't have a concrete timeline, but its high on the list as we prep for some larger improvements to the ecosystem.

@carbonrobot carbonrobot added the Type: TypeScript Issues related to typescript or type definitions label Jan 8, 2024
@jonkoops
Copy link
Author

@carbonrobot I think this one can be added to the "Improve bundle size" project as well.

@KenanYusuf KenanYusuf self-assigned this Feb 2, 2024
@carbonrobot carbonrobot added the Issue: Accepted The submitted issue has been confirmed by the Victory core team label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Accepted The submitted issue has been confirmed by the Victory core team Type: TypeScript Issues related to typescript or type definitions
Projects
None yet
Development

No branches or pull requests

3 participants