Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jumps when zoom in #2762

Open
omid opened this issue Jan 31, 2024 · 8 comments
Open

Jumps when zoom in #2762

omid opened this issue Jan 31, 2024 · 8 comments
Labels
Issue: Accepted The submitted issue has been confirmed by the Victory core team Status: Help Wanted 🔨 Extra attention is needed Type: Bug 🐛 Oh no! A bug or unintentional behavior

Comments

@omid
Copy link

omid commented Jan 31, 2024

Describe the bug
There is a jump when you zoom in the chart!

Victory version
Your version at: https://formidable.com/open-source/victory/docs/victory-zoom-container/

Code Sandbox link
Your online example: https://formidable.com/open-source/victory/docs/victory-zoom-container/

To Reproduce
Just zoom in somewhere in the chart, like the screencast below.

Peek.2024-01-31.10-56.mp4

Desktop (please complete the following information):

  • OS: Linux
  • Browser: Chrome/Firefox
  • Version: latest of each
@carbonrobot
Copy link
Contributor

This appears to be working as intended. Can you describe what behavior are you expecting?

@omid
Copy link
Author

omid commented Jan 31, 2024

@carbonrobot I zoom in on exactly the dots. Between seconds 6 and 7, the dots disappear from the chart.
If you focus on the numbers on axises (in this case, x-axis) you'll see the number jumps from 0.5000 to 0.2802 in this case.

@carbonrobot
Copy link
Contributor

That's likely because we are using a circle to calculate the datum. Try this chart with static data.

https://formidable.com/open-source/victory/guides/brush-and-zoom/

@omid
Copy link
Author

omid commented Jan 31, 2024

same bug on that chart.
between seconds 6 and 7, jumps from 26.000 to 14.560.

Peek.2024-01-31.14-01.mp4

@carbonrobot
Copy link
Contributor

Thanks, now I understand what you are asking. Looks like at some point the zoom container loses its x/y handle and the steps become larger.

@carbonrobot carbonrobot added Type: Bug 🐛 Oh no! A bug or unintentional behavior Status: Help Wanted 🔨 Extra attention is needed labels Jan 31, 2024
@carbonrobot carbonrobot added the Issue: Accepted The submitted issue has been confirmed by the Victory core team label Feb 22, 2024
@yuryprokashev
Copy link

Hi guys,

I encountered the same problem with VictoryZoomContainer for VictoryCandleStick.
It happens when the minimumZoom is reached.
The chart jumps back in time when it happens.
Please, check out this video

I would expect it just stops zooming, leaving me with what had been rendered so far.

Here is the code

@carbonrobot
Copy link
Contributor

Please retest after the fix released in 37.1.1

@omid
Copy link
Author

omid commented Sep 6, 2024

@carbonrobot Thanks.
Nope, this bug still exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Accepted The submitted issue has been confirmed by the Victory core team Status: Help Wanted 🔨 Extra attention is needed Type: Bug 🐛 Oh no! A bug or unintentional behavior
Projects
None yet
Development

No branches or pull requests

3 participants