Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Docker image #123

Closed
wants to merge 8 commits into from
Closed

Updated Docker image #123

wants to merge 8 commits into from

Conversation

SimplisticCode
Copy link
Collaborator

Updated Docker image to fetch and put the documentation enricher in the path.
I furthermore included a shell script to run the tool easily with some default parameters.

Copy link
Collaborator

@podhrmic podhrmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to mention yourself in the README, since you are part of the team now.

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Copy link
Collaborator

@podhrmic podhrmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to mention yourself in the README, since you are part of the team now.

Copy link
Collaborator

@podhrmic podhrmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to mention yourself in the README, since you are part of the team now.

@podhrmic
Copy link
Collaborator

podhrmic commented Oct 5, 2022

@SimplisticCode any updates?

@podhrmic
Copy link
Collaborator

podhrmic commented Nov 2, 2022

If @kiniry is OK with unsigned commits, then we can merge this once @SimplisticCode tests and uploads the new image.

@kiniry
Copy link
Member

kiniry commented Jan 19, 2023

I'm testing this PR. Now that Ubuntu 22.10 came out, the Docker images for the 21 release are gone, so I've moved the base of this image back to 20 for testing.

@podhrmic
Copy link
Collaborator

I believe this MR is moot - DER has its own docker image, and the base image is already 22.04 (see here). I recommend closing this MR.

@kiniry
Copy link
Member

kiniry commented Jan 21, 2023

I have had to update the location of the RDE_RF tool from Simon's personal organization to its new home in Galois's.

I'm testing builds of the image now, and after successfully building, I'll push a new release to DockerHub.

@podhrmic
Copy link
Collaborator

@kiniry Simon didn't sign his commits - do you want to just merge as is?

podhrmic added a commit that referenced this pull request Feb 9, 2023
@podhrmic
Copy link
Collaborator

podhrmic commented Feb 9, 2023

Closing in favor of #138

@podhrmic podhrmic closed this Feb 9, 2023
@kiniry
Copy link
Member

kiniry commented Sep 18, 2024

We forgot to delete the branch. I'll take care of it.

@kiniry kiniry deleted the dockerImage branch September 18, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

merge HARDENS "classic" docker image with Simon's new docker image and publish to DockerHub
3 participants