Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specification for templates #22

Open
2 tasks
hhirsch opened this issue Oct 14, 2017 · 7 comments
Open
2 tasks

Specification for templates #22

hhirsch opened this issue Oct 14, 2017 · 7 comments

Comments

@hhirsch
Copy link
Member

hhirsch commented Oct 14, 2017

Templates are a way to save an xml for later import to our maps. This is for recurring geometry like e.g. stairs.

Use case:

  • Design the stairs once in blender

  • Save the template as a map file in the template directory

  • While working on a map pull up the templates and insert your stairs as often as you want to

  • Create spec

  • Create issues according to spec

If a reference or the full geometry is added when inserting a template is to be decided (both have a use case and maybe both are needed).
In blender it will be beneficial to have all parts of a template grouped.
I think adding the full geometry instead of a reference should be implemented first and is simpler to implement, too since it does not require changes to the client.

@SGOrava
Copy link
Contributor

SGOrava commented Oct 14, 2017

Add more informations.

@Geertiebear
Copy link

@SGOrava what I'm getting from this is templates are a way to save certain aspects of a map to save repeating yourself. In his example he uses stairs. Say you build stairs in blender and don't want to have to repeat making the stairs. You save the stairs as a template and then you can import the template so you can reuse it. I think it would be good to have this in the specification as well.

@SGOrava
Copy link
Contributor

SGOrava commented Oct 14, 2017

@Geertiebear actually this function is partially there, you can import map without erasing the current scene, what is missing are only some tweaks as:

  • Group all elements from newly imported map (import it as a group)
  • Improve the quality check
  • Should it be added as
    <import part="cemetery">
      <position>
      <rotation>
     ...
    </import>
    or directly written in the map ?
    I prefer import
  • No matter what you say it will be an option in import & export UI

PS: stair is the worst example, there are very good stairs generators

@hhirsch
Copy link
Member Author

hhirsch commented Oct 14, 2017

@Geertiebear @SGOrava I think adding the full geometry instead of a reference should be implemented first and is simpler to implement, too since it does not require changes to the client.

@Geertiebear
Copy link

I like the idea of import, but it we can first experiment with the feature and add full geometry first. If it works well we can move onto import.

@SGOrava
Copy link
Contributor

SGOrava commented Oct 14, 2017

@Geertiebear Please be more precise. What do you mean by full geometry ? Is it like support for rotation, position and scale or is there something else what i am missing ?

@Geertiebear
Copy link

For each import we define certain objects. For example with stairs there are a bunch of rectangles. That collection of rectangles is the "full geometry" is what I understand from what @hhirsch said. Hope that clarifies ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants