Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order Events need raising #9

Open
Greedquest opened this issue Sep 8, 2018 · 1 comment
Open

Order Events need raising #9

Greedquest opened this issue Sep 8, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@Greedquest
Copy link
Owner

The synchrolist raises buffered events on addition which is good for ui. But on sorting/filtering only 1 event is raised (1st change event).

Solution would be to have a clear from index method in content. First change index can be found then cleared from there raising no event and re added as normal. That gives proper re-ordering events although it would trigger a load more on-removal then on-addition events. Perhaps another limbo state is in-order

@Greedquest Greedquest added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Sep 8, 2018
@Greedquest
Copy link
Owner Author

Ok 9766f36 did make this change, but now sort on addition means things are added then removed for sorting then added back then removed for sorting etc. as sort only checks where te 1st item ends up, and needs to check all of them instead. Also we don't want to raise the onaddition event on unsorted things if sortonaddition is specified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant