Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report : if world directory is symlink, restore script deletes it #91

Open
ja-cop opened this issue Sep 20, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@ja-cop
Copy link

ja-cop commented Sep 20, 2024

Describe the bug
I usually put the world data on a different filesystem with more space than the filesystem with the rest of the server files. One way to do this is with a symlink, where world points to a different directory. The restore script seems to delete this symlink, create a regular directory and start filling it with files, which then runs out of space as the filesystem can't fit the world.

One workaround is to replace the symlink with a root-owned bind mount.

To Reproduce
Use the restore script with the symlink setup.

Expected behavior
The restore script would alter the contents of the world directory, but not the directory/link itself.

Versioning (please complete the following information):

  • OS: Debian 12
  • Minecraft Version(s): 1.19.2
  • Modloader(s):Forge
  • Mod Version: AdvancedBackups 3.6

Just wanted to add that with the workaround the restore worked well and was a big help to one of my players. Thanks for creating and sharing this mod! 🙂

@ja-cop ja-cop added the bug Something isn't working label Sep 20, 2024
@ja-cop
Copy link
Author

ja-cop commented Sep 20, 2024

I also noticed that the restore script creates a clibackup_*.zip file in the root of the server files - fortunately I had enough space for this file, but maybe it would make sense to put this file in the backups directory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant