Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow selected metadata fields to be ignored during tests. #536

Open
1 of 2 tasks
daw3rd opened this issue Aug 23, 2024 · 2 comments
Open
1 of 2 tasks

[Feature] Allow selected metadata fields to be ignored during tests. #536

daw3rd opened this issue Aug 23, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@daw3rd
Copy link
Member

daw3rd commented Aug 23, 2024

Search before asking

  • I searched the issues and found no similar issues.

Component

Library/core

Feature

Some transforms may produce non-repeatable metadata. For example, time to execute. In this case, the expected metadata will generally not match the test-generated metadata. It would be good to have a way to specify which keys of the metadata should be ignored in the comparison of test-generated and expected metadata.

Note, we have something similar for the parquet files in that we can specify which columns to not compare.

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@daw3rd daw3rd added the enhancement New feature or request label Aug 23, 2024
@daw3rd daw3rd changed the title [Feature] Allow some metadata field(s) to be ignored during tests. [Feature] Allow metadata field(s) to be ignored during tests. Aug 23, 2024
@daw3rd daw3rd changed the title [Feature] Allow metadata field(s) to be ignored during tests. [Feature] Allow selected metadata fields to be ignored during tests. Aug 23, 2024
@daw3rd
Copy link
Member Author

daw3rd commented Aug 23, 2024

This will need to be done for both the pure transform test and the launcher-based tests.

@blublinsky
Copy link
Collaborator

Wait, we do not compare metadata

@daw3rd daw3rd self-assigned this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants