Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to do about system? #250

Open
fdmalone opened this issue Aug 30, 2023 · 6 comments
Open

What to do about system? #250

fdmalone opened this issue Aug 30, 2023 · 6 comments

Comments

@fdmalone
Copy link
Collaborator

fdmalone commented Aug 30, 2023

This is just a tuple of the electron numbers so seems pretty redundant? It's also sort of annoying to do import Generic as HamGeneric.

We should probably just delete and pass the tuple in as needed? The wavefunction will also store the number of electrons (and presumably the walker)

@fdmalone fdmalone changed the title What to do about system What to do about system? Aug 30, 2023
@linusjoonho
Copy link
Collaborator

We kept it this way because we thought system could include information about symmetry too.
If we do k-points and space group symmetry, for instance, shouldn't that information be available through system?

@fdmalone
Copy link
Collaborator Author

What information are you thinking about? I would think the Hamiltonian would just have this information?

@linusjoonho
Copy link
Collaborator

Oh - is the list of k-points, for instance, a part of Hamiltonian?
Also, how about temperature?

@fdmalone
Copy link
Collaborator Author

I sort of feel like maybe these are just single parameters (temperature would be eaten by propagator for instance) and k-points which are a property of the Hamiltonian (they're in the definition of it, so it doesn't seem wrong right?) Anyway, not super important just popped into my head again.

@linusjoonho
Copy link
Collaborator

I like the idea of removing the class, but somebody must make the changes everywhere, right?

@fdmalone
Copy link
Collaborator Author

yeah, maybe next time I get motivated I will do it. It's not urgent and fairly easy to do. Just using github issues to think out loud lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants