From 133a93e8aa62ec4fb22feae771c5e46e39296ec3 Mon Sep 17 00:00:00 2001 From: Roman Lebedev Date: Fri, 13 Sep 2024 20:24:14 +0300 Subject: [PATCH 1/2] Bump minimal supported julia version to 1.6 In https://github.com/JuliaStats/Distributions.jl/pull/1900, dependency on Roots.jl is being added, which only supports julia 1.6+ --- .github/workflows/CI.yml | 4 ++-- Project.toml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 886724bd2..eb6d22610 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -23,7 +23,7 @@ jobs: fail-fast: false matrix: version: - - '1.3' + - '1.6' - '1' - pre os: @@ -36,7 +36,7 @@ jobs: with: version: ${{ matrix.version }} # ARM64 on macos-latest is neither supported by older Julia versions nor setup-julia - arch: ${{ matrix.os == 'macos-latest' && matrix.version != '1.3' && 'aarch64' || 'x64' }} + arch: ${{ matrix.os == 'macos-latest' && matrix.version >= '1.8' && 'aarch64' || 'x64' }} show-versioninfo: true - uses: julia-actions/cache@v2 - uses: julia-actions/julia-buildpkg@v1 diff --git a/Project.toml b/Project.toml index af12e4b7a..c26d0206a 100644 --- a/Project.toml +++ b/Project.toml @@ -57,7 +57,7 @@ StatsAPI = "1.6" StatsBase = "0.32, 0.33, 0.34" StatsFuns = "0.9.15, 1" Test = "<0.0.1, 1" -julia = "1.3" +julia = "1.6" [extras] Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595" From 6a2ef5a385068b78289fd5f8c978dd143568e196 Mon Sep 17 00:00:00 2001 From: Roman Lebedev Date: Fri, 13 Sep 2024 20:53:45 +0300 Subject: [PATCH 2/2] Disable Aqua tests for julia 1.6 too I *think* this is a false-positive: ``` Running tests: 1 ambiguities found. To get a list, set `broken = false`. Ambiguity #1 frule(::ChainRulesCore.RuleConfig, args...) in ChainRulesCore at /home/runner/.julia/packages/ChainRulesCore/I1EbV/src/rules.jl:64 frule(::Any, ::typeof(Distributions.logpdf), d::Distributions.Uniform, x::Real) in Distributions.DistributionsChainRulesCoreExt at /home/runner/work/Distributions.jl/Distributions.jl/ext/DistributionsChainRulesCoreExt/univariate/continuous/uniform.jl:1 Possible fix, define frule(::ChainRulesCore.RuleConfig, ::typeof(Distributions.logpdf), ::Distributions.Uniform, ::Real) Aqua: Test Failed at /home/runner/.julia/packages/Aqua/tHrmY/src/ambiguities.jl:78 Expression: iszero(num_ambiguities) Stacktrace: [1] _test_ambiguities(packages::Vector{Base.PkgId}; broken::Bool, kwargs::Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}) @ Aqua ~/.julia/packages/Aqua/tHrmY/src/ambiguities.jl:78 [2] _test_ambiguities @ ~/.julia/packages/Aqua/tHrmY/src/ambiguities.jl:69 [inlined] [3] test_ambiguities(packages::Module; kwargs::Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}) @ Aqua ~/.julia/packages/Aqua/tHrmY/src/ambiguities.jl:28 [4] test_ambiguities(packages::Module) @ Aqua ~/.julia/packages/Aqua/tHrmY/src/ambiguities.jl:28 [5] macro expansion @ ~/work/Distributions.jl/Distributions.jl/test/aqua.jl:19 [inlined] [6] macro expansion @ /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Test/src/Test.jl:1151 [inlined] [7] top-level scope @ ~/work/Distributions.jl/Distributions.jl/test/aqua.jl:9 ``` --- test/aqua.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/aqua.jl b/test/aqua.jl index 4dd8c0706..99e8a752a 100644 --- a/test/aqua.jl +++ b/test/aqua.jl @@ -15,7 +15,7 @@ import Aqua ) # Tests are not reliable on older Julia versions and # show ambiguities in loaded packages - if VERSION >= v"1.6" + if VERSION >= v"1.7" Aqua.test_ambiguities(Distributions) end end