Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misleading test names in test_spirv_new for no integer wrap decoration #2057

Open
bashbaug opened this issue Aug 22, 2024 · 0 comments
Open

misleading test names in test_spirv_new for no integer wrap decoration #2057

bashbaug opened this issue Aug 22, 2024 · 0 comments
Labels
cleanup/refactoring

Comments

@bashbaug
Copy link
Contributor

See review comment: #2041 (comment)

The test names and SPIR-V asm filenames for the "no integer wrap decoration" tests are "fadd", "fsub", etc., which implies that they're testing floating-point operations, but they're actually testing integer operations. We should fix this by renaming the test names and the SPIR-V asm files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup/refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@svenvh @bashbaug