Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution swamped with shader projects #1156

Open
asuessenbach opened this issue Sep 9, 2024 · 2 comments · May be fixed by #1164
Open

Solution swamped with shader projects #1156

asuessenbach opened this issue Sep 9, 2024 · 2 comments · May be fixed by #1164
Assignees
@gpx1000

Comments

@asuessenbach
Copy link
Contributor

With PR #1130, the solution (VS2022-speak) is filled with lots of top-level shader projects.
Is that intended?
Shouldn't we at least move them into some "shaders"-folder, or so?
@SaschaWillems
Copy link
Collaborator

100% not intended. Somehow didn't happen when I reviewed it, but when doing a cmake clean and full rebuild of the project I get that too. Moving them into a folder would be an option, but I'd rather prefer not having them at all. Shaders are already accessible from the respective samples.

@gpx1000 : Any suggestions?

@gpx1000
Copy link
Collaborator

gpx1000 commented Sep 10, 2024

top level shader projects? Does VS now make cmake tasks into shader projects?!? ... sorry not intended... Maybe let's move them into folders for now, and let's look into making them subtasks for each sample; which probably is the right way to do it.

@gpx1000 gpx1000 linked a pull request Sep 12, 2024 that will close this issue
Open
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gpx1000 gpx1000

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move the hlsl shader tasks into their own folder gpx1000/Vulkan-Samples
3 participants
@gpx1000 @SaschaWillems @asuessenbach