Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute derivative workgroup size error checks may raise false positives #3724

Open
jeffbolznv opened this issue Sep 12, 2024 · 1 comment
Open

Comments

@jeffbolznv
Copy link
Contributor

jeffbolznv commented Sep 12, 2024

Thanks for merging. I just noticed that since this is doing the checks as it parses the shader, whether you get an error depends on the order of setting the derivative layout vs setting the workgroup dimensions (spec constant or not). This is a pre-existing issue and not a huge deal for me, but maybe worth fixing eventually.

Originally posted by @jeffbolznv in #3723 (comment)

@jeffbolznv
Copy link
Contributor Author

To reproduce, just change the order of the derivative layout and workgroup size layout in the computeShaderDerivatives* tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants