Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gn build failed due to missing visibility.h dependency #3727

Open
HuYuxin opened this issue Sep 13, 2024 · 2 comments
Open

gn build failed due to missing visibility.h dependency #3727

HuYuxin opened this issue Sep 13, 2024 · 2 comments

Comments

@HuYuxin
Copy link
Contributor

HuYuxin commented Sep 13, 2024

After this commit , projects relies on BUILD.gn to compile runs into below error:

ERROR at //third_party/glslang/src/glslang/Public/ResourceLimits.h:41:11: Include not allowed.
#include "../Include/visibility.h"
          ^----------------------
It is not in any dependency of
  //third_party/glslang/src:glslang_default_resource_limits_sources
The include file is in the target(s):
  //third_party/glslang/src:glslang_lib_sources
  //third_party/glslang/src:glslang_sources
at least one of which should somehow be reachable.
This might be a false alarm if you are using conditional include. See "gn help nogncheck".

Would you help us make below change in BUILD.gn file to fix the error?

@@ -302,6 +302,7 @@ source_set("glslang_default_resource_limits_sources") {
     "glslang/ResourceLimits/ResourceLimits.cpp",
     "glslang/Public/ResourceLimits.h",
     "glslang/Include/ResourceLimits.h",
+    "glslang/Include/visibility.h"
   ]
@HuYuxin
Copy link
Contributor Author

HuYuxin commented Sep 13, 2024

To help better integration with GN based projects, could we consider adding Android GN build to Github CI, like KhronosGroup/Vulkan-ValidationLayers@5974d40.

@HuYuxin
Copy link
Contributor Author

HuYuxin commented Sep 16, 2024

pull request for this issue is created here: #3730

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant