Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: use "platform" to mean web/desktop, "osFamily" to mean mac/windows/linux #3880

Open
franknoirot opened this issue Sep 13, 2024 · 0 comments
Open

Chore: use "platform" to mean web/desktop, "osFamily" to mean mac/windows/linux #3880

franknoirot opened this issue Sep 13, 2024 · 0 comments
Labels
low-priority refactor

Comments

@franknoirot
Copy link
Collaborator

@jtran made a good point in this PR:

Hmm, we already use "platform" to mean "OS" (see src/lib/utils.ts). Ideally we don't use the same term to talk about multiple things. I think I like this new definition better. We should probably rename the existing uses at some point to osFamily or something.

Clean up any instances of the word "platform" to fit this definition, and move that getPlatformString function I made in that PR to a more centralized utility spot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low-priority refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@franknoirot