Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Numpy 2.0 #12

Closed
fra-pcmgf opened this issue Jun 19, 2024 · 2 comments · Fixed by #14
Closed

Support for Numpy 2.0 #12

fra-pcmgf opened this issue Jun 19, 2024 · 2 comments · Fixed by #14
Assignees

Comments

@fra-pcmgf
Copy link
Collaborator

fra-pcmgf commented Jun 19, 2024

Numpy 2 has some breaking changes (https://numpy.org/devdocs/numpy_2_0_migration_guide.html), so GeneTrajectory-python should be updated and rebuilt to work with it.

It looks doable but we depend on packages that are not numpy 2 ready yet:

@fra-pcmgf
Copy link
Collaborator Author

The current situation is

  • the new version of POT works well
  • scikit-misc made a new version but doesn't fully support Mac at the moment
  • scanpy has pinned numpy < 2.0

Also, I noticed we should require numpy>=1.25 instead because we are using np.linalg.eigh as named tuple.

@fra-pcmgf fra-pcmgf linked a pull request Aug 4, 2024 that will close this issue
@fra-pcmgf
Copy link
Collaborator Author

Note: this package supports numpy 2.0 but scanpy doesn't yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant