chore: updated go-database-reconciler to v1.14.5 #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1380 +/- ##
==========================================
+ Coverage 22.42% 22.49% +0.06%
==========================================
Files 54 54
Lines 4517 4517
==========================================
+ Hits 1013 1016 +3
+ Misses 3404 3402 -2
+ Partials 100 99 -1 ☔ View full report in Codecov by Sentry. |
This version of go-database-reconciler has the fix that ensures that plugins are not shown as global if they have a consumer group attached. Earlier, they were wrongly shown as global, despite the actual associations working fine. Fixes #1005
Prashansa-K
force-pushed
the
fix/plugin-association-mismatch
branch
from
c5bb64e
to
490519f
Compare
|
@GGabriele Could you please approve this? |
GGabriele
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version of go-database-reconciler has the fix that ensures that plugins are not shown as global
if they have a consumer group attached.
Earlier, they were wrongly shown as global, despite the actual associations working fine.
Fixes #1005
GDR PR with the fix: Kong/go-database-reconciler#134