Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have federated lemmy servers download images from thumbnail_url (image cache) of fedilink instance, instead of user-submitted image link #4899

Open
5 tasks done
aeharding opened this issue Jul 14, 2024 · 3 comments
Labels
area: federation support federation via activitypub area: media enhancement New feature or request

Comments

@aeharding
Copy link

aeharding commented Jul 14, 2024

Requirements

  • Is this a feature request? For questions or discussions use https://lemmy.ml/c/lemmy_support
  • Did you check to see if this issue already exists?
  • Is this only a feature request? Do not put multiple feature requests in one issue.
  • Is this a backend issue? Use the lemmy-ui repo for UI / frontend issues.
  • Do you agree to follow the rules in our Code of Conduct?

Is your proposal related to a problem?

The original image URL may break before all lemmy instances have a chance to cache it. This results in posts with broken images for some users, but not others.

Describe the solution you'd like.

In my observations, the fedilink lemmy server has usually successfully cached the image.

So, have federated lemmy instances use the fedilink lemmy server's post.thumbnail_url to download/cache the image, instead of (or as a fallback to) the post.url image link.

Describe alternatives you've considered.

This behavior could be a fallback, or the default behavior.

Or it could be left the way it is. However, this problem pops up fairly often with flakey image hosts like https://i.ibb.co

Additional context

See user complaint: https://lemmy.world/comment/11176251 (please note that this is not a Voyager-specific issue)

@aeharding aeharding added the enhancement New feature or request label Jul 14, 2024
@dullbananas dullbananas added the area: federation support federation via activitypub label Jul 14, 2024
@lullis
Copy link
Contributor

lullis commented Jul 16, 2024

Can't this be solved by the client?

@aeharding
Copy link
Author

aeharding commented Jul 16, 2024

Technically yes, but not without the client making an API request to the arbitrary upstream Lemmy server, per failing post image. (Not great for privacy.)

A backend solution would preserve user privacy, and also work by default on all clients. So if this can be implemented in the backend, I think it should be.

@lullis
Copy link
Contributor

lullis commented Jul 17, 2024

@aeharding maybe I should move this discussion elsewhere, but would you be interested in having support to some form of proxy server that can resolve image urls?

I'm thinking of adding support to IPFS links on fediverser, which would allow clients to query for an image CID and get it from an independent IPFS server. It would solve the privacy issue and it would provide some relief for media servers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: federation support federation via activitypub area: media enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants