Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: 404 error when using pagination #94

Closed
593kdk32idk32 opened this issue Apr 24, 2023 · 2 comments
Closed

[Bug]: 404 error when using pagination #94

593kdk32idk32 opened this issue Apr 24, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@593kdk32idk32
Copy link

593kdk32idk32 commented Apr 24, 2023

Steps to reproduce

  1. Install LemmyBB 0.2.1 or 0.2.2
  2. Link to a separate Lemmy instance with enough content to have pagination available.
  3. Click one of the pagination numbers at the top or bottom. ( 2, 3, 4 or > )
  4. See 404 page instead of content.

Version

0.2.1 or 0.2.2. Earlier versions not tested.

LemmyBB Logs

Click the page number or > and see an error like this in the log. The actual page=NUM will change depending on what you click.

[2023-04-24T21:21:07Z ERROR rocket::server::_] No matching routes for GET /viewforum?f=8&page=2 text/html.
[2023-04-24T21:21:07Z WARN  rocket::server::_] No 404 catcher registered. Using Rocket default.

Additional context

Maybe related to #89, but in this case I see a 404 instead of being returned to page one.

@593kdk32idk32 593kdk32idk32 added the bug Something isn't working label Apr 24, 2023
@Nutomic
Copy link
Member

Nutomic commented May 2, 2023

This is because Lemmy doesnt provide any information how many pages there are. This means that the page numbers which are shown go higher than the actual last page.

Providing a page count from Lemmy would be a bit tricky because it needs to take account for blocked users and many other things. Im not sure how else this could be solved, maybe it would be better to remove the page buttons entirely for now?

@Nutomic
Copy link
Member

Nutomic commented May 10, 2023

Sorry I misunderstood the issue, solved in #96.

@Nutomic Nutomic closed this as completed May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants