-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update underlying docker image or use third party one #80
Comments
Sounds good @fjgarlin. I think that it makes sense to update the Dockerfile to create a new image. As for where to store the image, I would prefer GitHub's Container Registry rather than Docker Hub since now in Docker hub you need to pay in order to do automated builds. |
+1 for upgrading base image, I recently upgraded my Drupal site to use PHP 8.1, but getting error on CI as image is still stuck at PHP 8.0. |
An attempt at this is made here: #81 -- Just thinking out loud here... I wonder how difficult would it be to add |
In one of my personal project, I'm using following in
|
Perhaps the next major version of this project could be an interactive command line interface. Thoughts @fjgarlin ? |
That would be something really cool to get. Give the users a few options to choose from and then generate everything with the right versions. I really like the idea. |
I am going to start creating one using https://github.com/spf13/cobra-cli |
While working on #79 it was obvious that a lot has changed since last year (as it should in our world).
So the suggestion is to create a new image with the latest and brightest (for now) and change all instances of
juampynr/drupal8ci:latest
for that new one. Or to leverage an existing image which has what we need in it.We can probably get an image with most of our needs out there, and then maybe add the latest LTS node and a few other useful tools to it.
The work here is mostly on the
Dockerfile(9)
s and then the image will need to be uploaded to dockerhub. Once this is done we can change and test the rest of the code.Related issues/PRs:
The text was updated successfully, but these errors were encountered: