Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option dependencies #47

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Option dependencies #47

wants to merge 5 commits into from

Conversation

Lutymane
Copy link

@Lutymane Lutymane commented Apr 23, 2024 •
edited
Loading

fix #46

  • added loading popup when fetching nodes
  • added options confirmation modal before sending file for obfuscation

memcorrupt
memcorrupt reviewed Apr 25, 2024
View reviewed changes
src/extension.ts

const nodesPromise = luraphApi.getNodes();

vscode.window.withProgress(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note to self: what does this do?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shows a pop up with loading indicator which closes when promise resolves

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memcorrupt memcorrupt memcorrupt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to handle setting dependencies
2 participants
@Lutymane @memcorrupt