Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timestamps, client ip & name, pid to mdsip error logs, equivalent to "access" logs #2789

Open
vadim-at-te opened this issue Jun 12, 2024 · 1 comment
Assignees
Labels
duplicate There exists similar issues, pull requests, or discussions feature Indicates new feature requests or implementations tool/mdsip Relates to one of the MDSplus over IP tools (mdsipd, mdsipsd, mdsip_server)

Comments

@vadim-at-te
Copy link

vadim-at-te commented Jun 12, 2024

Affiliation
Tokamak Energy, 173 Brook Dr, Milton, Abingdon, UK

Description
MDSplus mdsip error logs are stored (by default) at /var/log/mdsplus/mdsipd/errors. The log entries do not have timestamps, process id, client ip - and this makes it much harder to troubleshoot connectivity problems. This is in contrast to /var/log/mdsplus/mdsipd/access entries which had all this information

Example
I don't have a pseudocode but I am happy to implement the feature myself and submit it to a merge review if you point me in the right direction in your massive code base. Here are examples of a well-structure entries in "access" file and non-informative entries in "errors" file:

$ tail -1 /var/log/mdsplus/mdsipd/access
Wed Jun 12 09:07:12 2024 (0) (pid 1602200) Connection received from peter. ...REDACTED...@s...REDACTED....local [192....REDACTED-IP...]
$ tail -1 /var/log/mdsplus/mdsipd/errors
Connected: James....REDACTED-lastname

Notice how the error logs are more or less useless.

Additional context
Thank you in advance

@mwinkel-dev mwinkel-dev added duplicate There exists similar issues, pull requests, or discussions tool/mdsip Relates to one of the MDSplus over IP tools (mdsipd, mdsipsd, mdsip_server) core Relates to the core libraries and scripts labels Jun 13, 2024
@mwinkel-dev
Copy link
Contributor

Hi @vadim-at-te -- Yes, the mdsip service definitely needs better logging. Thanks for listing the requirements for your site.

Note that this request is a duplicate of #2683.

@mwinkel-dev mwinkel-dev added feature Indicates new feature requests or implementations and removed core Relates to the core libraries and scripts labels Jun 13, 2024
@WhoBrokeTheBuild WhoBrokeTheBuild self-assigned this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate There exists similar issues, pull requests, or discussions feature Indicates new feature requests or implementations tool/mdsip Relates to one of the MDSplus over IP tools (mdsipd, mdsipsd, mdsip_server)
Projects
None yet
Development

No branches or pull requests

3 participants