Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update controllers to conform to controller-messenger pattern #2073

Closed
MajorLift opened this issue Nov 21, 2023 · 1 comment
Closed

Update controllers to conform to controller-messenger pattern #2073

MajorLift opened this issue Nov 21, 2023 · 1 comment

Comments

@MajorLift
Copy link
Contributor

MajorLift commented Nov 21, 2023

Motivation

A number of controllers currently undergoing active development are extending from the deprecated BaseController class, and not conforming to the controller-messenger pattern. As part of Shared Libraries team OKRs, these controllers should be updated so that they adhere to current practices.

Tasks

  • Controllers that currently extend from BaseController should be updated to extend from BaseControllerV2.

    • core

      • AbstractMessageManager
      • AccountTrackerController
      • AddressBookController
      • AssetsContractController
      • ComposableController
      • NftController
      • PhishingController
      • PreferencesController
      • RateLimitController
      • TokenBalancesController
      • TokensController
      • TransactionController
    • external

      • SwapsController
  • Controllers that currently extend from PollingControllerOnly or PollingControllerV1 should be updated to extend from PollingController.

    • core

      • NftDetectionController
      • TokenDetectionController
      • TokenRatesController
    • external

      • SmartTransactionsController
@MajorLift
Copy link
Contributor Author

Closing as duplicate of #1509

@MajorLift MajorLift closed this as not planned Won't fix, can't repro, duplicate, stale Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant