Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amon Hen V2 Snaps API Plan #2578

Open
ajeetd opened this issue Jul 15, 2024 · 3 comments
Open

Amon Hen V2 Snaps API Plan #2578

ajeetd opened this issue Jul 15, 2024 · 3 comments
Assignees

Comments

@ajeetd
Copy link

ajeetd commented Jul 15, 2024

This is a research and planning story to consider an approach to handling the points discussed in this conversation: https://consensys.slack.com/archives/C03Q3TCUVRT/p1720794034563159

Specifically:

  • Currently Snaps are set to the current globally selected chain and this works now because Snaps are always set to the same chain as whatever the user sees in the UI
  • Going forward this will no longer be the case. We will start to see confirmations for a different chain than the globally selected chain. This means for instance that transaction insight snaps wont have the correct chain state.

Suggestions offered in the conversation:

  • Tie selected network for all Snaps to whatever network is represented in UI. If we are on a confirmation, all Snaps could have teh same network selected as the dapp that is requesting the confirmation. Otherwise use the globally selected network.
  • Set the selected chain of each tx insight snap to whatever chain is relevant for the current confirmation if there are any possible insights for this confirmation

See linked thread for the whole conversation.

Acceptance Criteria

  • At this point, put together a one pager proposal of an approach.
@ajeetd
Copy link
Author

ajeetd commented Jul 16, 2024

@Mrtenz Please Slack thread linked above for context. No action required at this time other than being aware of the context and starting to consider approaches when time available.

@ajeetd
Copy link
Author

ajeetd commented Aug 30, 2024

@Mrtenz - please close unless there's anything else left here.

@Mrtenz
Copy link
Member

Mrtenz commented Aug 30, 2024

This work isn't merged yet so I think we should keep this open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants