Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some needed functionalities are missing #9

Open
amirsaam opened this issue Sep 3, 2024 · 3 comments
Open

Some needed functionalities are missing #9

amirsaam opened this issue Sep 3, 2024 · 3 comments

Comments

@amirsaam
Copy link

amirsaam commented Sep 3, 2024

Hello,
First of all thanks for your effort on the package.

Since I am trying to use your Timer in my project, unfortunately lack of some functionalities are hardly noticed.

  1. When timer ends, timer needs to have a Bool to notify UI about it, isTimerRunning is good only about the current situation of Timer that becomes false when you pause it and you are able to resume it but there is no result of the timer to know actually it did finish to run other actions when it did "actually" finish.
  2. Timer has no abort/skip functionality, as a whole you may think you don't need such but actually as in my project be able to skip/abort the timer and get the finished boolean as mentioned in # 1 is crucial.
  3. Timer is no class friendly to be used in ViewModels for example. The Bindings in the initialisers are making it not work unless you import SwiftUI and make custom Binding to the Published variables.

As a request, please add extra initialisers to be able to just pass them variables in classes, abort/skip functionality and a finish report.

Thanks again for your package.

@amirsaam
Copy link
Author

amirsaam commented Sep 4, 2024

@FulcrumOne sorry for the mention, but any help?

@FulcrumOne
Copy link
Contributor

Hey @amirsaam,

I'm so sorry, but unfortunately currently I can't work on it as I'm busy with three other projects:

  1. I'm updating all the libraries we have (7) to make sure they will work in the upcoming iOS
  2. I'm working on the newest library (MediaPicker) to be published
  3. I've started implementing a new model that should attract more collaborators to help us maintain our libraries

For the above reasons, the earliest I could implement the features you have asked for (which I completely agree with) is the completion of point 1 (probably around 12 September, and it will take 1-2 days to implement the new features).

Once again, I'd like to apologise for this, but I'm literally the only person who maintains all the libraries, creates new ones and has a job outside of that, so my schedule is little tight.

Let me know if the above solution works for you and have a nice day 😉,
Tomasz K.

@amirsaam
Copy link
Author

amirsaam commented Sep 4, 2024

@FulcrumOne Sounds awesome to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants