Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant units='none' arguments in register_*_field calls #78

Open
uramirez8707 opened this issue Dec 28, 2022 · 0 comments
Open

Comments

@uramirez8707
Copy link
Contributor

In some register_*_field calls in full,simple/atm_land_ice_flux_exchange.F90, the optional argument units is pass in as "none":

id_land_mask = &
register_static_field ( mod_name, 'land_mask', atmos_axes, &
'fractional amount of land', 'none', &
range=frange, interp_method = "conserve_order1" )
!--------- initialize diagnostic fields --------------------
id_ice_mask = &
register_diag_field ( mod_name, 'ice_mask', atmos_axes, Time, &
'fractional amount of sea ice', 'none', &
range=frange, interp_method = "conserve_order1" )
id_wind = &
register_diag_field ( mod_name, 'wind', atmos_axes, Time, &
'wind speed for flux calculations', 'm/s', &
range=(/0.,vrange(2)/) )
id_drag_moist = &
register_diag_field ( mod_name, 'drag_moist', atmos_axes, Time, &
'drag coeff for moisture', 'none' )
id_drag_heat = &
register_diag_field ( mod_name, 'drag_heat', atmos_axes, Time, &
'drag coeff for heat', 'none' )
id_drag_mom = &
register_diag_field ( mod_name, 'drag_mom', atmos_axes, Time, &
'drag coeff for momentum', 'none' )

This is redundant because, diag manager does not write it anyway:
https://github.com/NOAA-GFDL/FMS/blob/203c8bf464ff26fe0fe39b1451caedd026bbce55/diag_manager/diag_output.F90#L651-L652

Dimensionless variables are not required to have units to be cf compliant. I think these units='none' arguments should be removed from the register_*field calls. It won't change any behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant