Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jd/index fixes #89

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Jd/index fixes #89

wants to merge 4 commits into from
+4 −4

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Sep 21, 2024

closes #86

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 21, 2024 •
edited
Loading

Performance Results

Version Precompile Time
Main 1.154152691
This Branch 1.142039149
Version Execute Time
Main-Build PTDF First 5.338756986
Main-Build PTDF Second 0.084632496
Main-Build Ybus First 0.367903162
Main-Build Ybus Second 0.007406335
Main-Build LODF First 1.059519732
Main-Build LODF Second 0.205976549
This Branch-Build PTDF First 5.293264658
This Branch-Build PTDF Second 0.110059105
This Branch-Build Ybus First 0.365852828
This Branch-Build Ybus Second 0.007257838
This Branch-Build LODF First 1.045519506
This Branch-Build LODF Second 0.299187976

@codecov Codecov
Copy link

codecov bot commented Sep 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.92%. Comparing base (0ba509b) to head (ec72d8d).

Files with missing lines Patch % Lines
src/ybus_calculations.jl 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
- Coverage   77.93%   77.92%   -0.02%     
==========================================
  Files          15       15              
  Lines        1396     1395       -1     
==========================================
- Hits         1088     1087       -1     
  Misses        308      308
Flag Coverage Δ
unittests 77.92% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/ptdf_calculations.jl 93.03% <100.00%> (-0.04%) ⬇️
src/ybus_calculations.jl 41.23% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigomha rodrigomha Awaiting requested review from rodrigomha

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjacency function UndefVarError
1 participant
@jd-lara