Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: Set up codeowners and automatic review assignment #137

Closed
1 task done
jrhemstad opened this issue Jun 28, 2023 · 0 comments · Fixed by #226
Closed
1 task done

[FEA]: Set up codeowners and automatic review assignment #137

jrhemstad opened this issue Jun 28, 2023 · 0 comments · Fixed by #226
Labels
infrastructure Shared CMake, github, etc infrastructure

Comments

@jrhemstad
Copy link
Collaborator

jrhemstad commented Jun 28, 2023

Is this a duplicate?

Area

Infrastructure

Is your feature request related to a problem? Please describe.

I would like certain individuals to be requested/required to review certain files.

Describe the solution you'd like

  • Code ownership will be set for the following directories:
    • thrust/ - @nvidia/cccl-thrust-codeowners
    • cub/ - @nvidia/cccl-cub-codeowners
    • libcudacxx/ - @nvidia/cccl-libcudacxx-codeowners
    • .github/, ci/, .devcontainer/ - @nvidia/cccl-infra-codeowners
  • Any CMakeLists.txt files and cmake/ directories are owned by @nvidia/cccl-cmake-codeowners.
  • General code ownership for all files in the repository is assigned to @nvidia/cccl-codeowners.

(Membership for these teams has not been established yet)

When a new pull request is created, GitHub will now automatically request a review from the specific code owner(s) corresponding to the changed files, as well as a review from the general team (@cccl-codeowners). Therefore, each pull request will need to be approved by both a specific code owner and a general team member before it can be merged.

@miscco miscco added the infrastructure Shared CMake, github, etc infrastructure label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Shared CMake, github, etc infrastructure
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants