Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA]: Update -Werror all-warnings to -Werror=all-warnings in libcudacxx tests to enable sccache #150

Closed
1 task done
jrhemstad opened this issue Jun 29, 2023 · 1 comment · Fixed by #147
Closed
1 task done

[FEA]: Update -Werror all-warnings to -Werror=all-warnings in libcudacxx tests to enable sccache #150

jrhemstad opened this issue Jun 29, 2023 · 1 comment · Fixed by #147
Assignees
@miscco

Comments

@jrhemstad
Copy link
Collaborator

Is this a duplicate?

Area

libcu++

Is your feature request related to a problem? Please describe.

We rely on sccache to accelerate local and CI builds.

sccache currently isn't working for libcudacxx tests.

I narrowed this down to the fact that sccache doesn't recognize -Werror all-warnings (see similar issue in PyTorch pytorch/pytorch#37928).

It turns out that -Werror=all-warnings will fix the issue.

Describe the solution you'd like

Update the libcudacxx test configs to use -Werror=all-warnings instead.

Describe alternatives you've considered

No response

Additional context

No response
@miscco miscco linked a pull request Jun 29, 2023 that will close this issue
Add ccache to lit invocation #147
Merged
@jrhemstad
Copy link
Collaborator Author

This should have auto closed with #147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miscco miscco

Labels
None yet
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ccache to lit invocation miscco/cccl
2 participants
@miscco @jrhemstad